open-telemetry / opentelemetry-collector-releases

OpenTelemetry Collector Official Releases
https://opentelemetry.io
Apache License 2.0
220 stars 130 forks source link

Consistency for configuration for distros #530

Open codeboten opened 2 months ago

codeboten commented 2 months ago

Configuration is in different places for the different distros:

# contrib
/etc/otelcol-contrib/config.yaml
# core
/etc/otelcol/config.yaml
# k8s distro
No conf

It would be great to have it be consistent

mx-psi commented 2 months ago

This was intentional https://github.com/open-telemetry/opentelemetry-collector-releases/issues/59#issuecomment-1014451868

I don't like having a default config because:

Although removing the default config is a breaking change, the blast radius is probably going to be more reduced (at least if we keep the entrypoint as is), since most people are not using the default configuration

TylerHelmuth commented 2 months ago

I agree on removing default config

jpkrohling commented 2 months ago

I'm also in favor of removing the default config.

It leads to a silent failure (using the default config) if you get the command wrong/mount the config in the wrong place

I've seen this many times as well.