open-telemetry / opentelemetry-collector-releases

OpenTelemetry Collector Official Releases
https://opentelemetry.io
Apache License 2.0
252 stars 163 forks source link

Current workflow allows partial releases when CI fails for a single distro #571

Open mx-psi opened 5 months ago

mx-psi commented 5 months ago

During the v0.102.0 we ran into an issue with #560 that caused the release of core and contrib distros to fail (see https://github.com/open-telemetry/opentelemetry-collector-releases/pull/560#issuecomment-2147343522).

In the release, I cancelled the k8s distro release https://github.com/open-telemetry/opentelemetry-collector-releases/actions/runs/9366469958/job/25784146751. This would have passed, since we don't support this distro on Windows.

I cancelled it since we use the same tag for all distros and it would have led to an awkward state where we release different distros from different versions of the same tag, but I was lucky: had I not been paying attention, we would have had to have two partial releases.

Is this a problem? What should we do to address this if so?

TylerHelmuth commented 5 months ago

We talked a little about this topic in https://github.com/open-telemetry/opentelemetry-collector-releases/issues/429. In my opinion we should be releasing each distro with its own tag push, instead of releasing all distros based on the same tag push.

This allows each distro to be released completely independently. In your situation the k8s distro would have been allowed to finish its release without issues while you worked on fixing Contrib and Core.