search

open-telemetry / opentelemetry-collector-releases

OpenTelemetry Collector Official Releases
https://opentelemetry.io
Apache License 2.0
252 stars 162 forks source link

Re-add flag for ocb build to enable version number #665

Closed jackgopack4 closed 1 month ago

jackgopack4 commented 2 months ago

Description This re-enables the functionality to set a version number for ocb binary (cmd/builder). It was erroneously removed.

Link to tracking issue Along with https://github.com/open-telemetry/opentelemetry-collector/pull/11208, closes https://github.com/open-telemetry/opentelemetry-collector-releases/issues/664.

Testing ran build and release cycles inside personal fork repositories (jackgopack4/opentelemetry-collector and jackgopack4/opentelemetry-collector-releases)

Documentation none, small bugfix

mx-psi commented 2 months ago

Do we need https://github.com/open-telemetry/opentelemetry-collector/pull/11208 before merging this?

jackgopack4 commented 2 months ago

@mx-psi we don't need #11208 before merging this; ocb will still build with this flag but it won't successfully get the version from cobra command unless #11208 is also merged, so we can't close #664 until then

chan-tim-sumo commented 2 months ago

hey @TylerHelmuth can you take a look at this PR? currently blocked from this since this is needed to get a new release out for customers from my side. thanks!