open-telemetry / opentelemetry-collector-releases

OpenTelemetry Collector Official Releases
https://opentelemetry.io
Apache License 2.0
252 stars 162 forks source link

Container image doesn't export http receiver 4318 #692

Closed abraxxa closed 1 month ago

abraxxa commented 1 month ago

The Perl OpenTelemetry::Exporter::OTLP module currently only supports the http protocol and not grpc. The config enables the http receiver but the Dockerfile doesn't expose it. Why?

dosubot[bot] commented 1 month ago

Hey @abraxxa! 👋 I'm here to help you with bug fixes, answer your questions, and assist you in becoming a contributor. Let's squash those bugs together!

The otelcol-contrib Dockerfile exposes ports 4317, 55678, and 55679, but it does not explicitly expose port 4318, which is used by the HTTP receiver in the configuration [1]. You might need to modify the Dockerfile to include EXPOSE 4318 to ensure the HTTP receiver is accessible.

To continue talking to Dosu, mention @dosu.

mowies commented 1 month ago

The dockerfile EXPOSE statement is more for documentation than anything else (see dockerfile docs). So it doesn't actually impact whatever the collector listens to in the container.

But I agree that it should still be aligned for consistency.

abraxxa commented 1 month ago

FYI the Docker Desktop UI lets you only expose ports that are specified in the Dockerfile with EXPOSE. Using the CLI was my workaround.

mowies commented 1 month ago

Ah ok I'm not that familiar with the UI :) Then it should definitely be updated

mx-psi commented 1 month ago

@abraxxa would you be willing to file a PR for this? We can help you get it into the right shape so we can merge it :)

abraxxa commented 1 month ago

I think the time you spend on reviewing the PR is about the same as if you commit it yourself ;-) But if you want it for some other reason I can do it.

mx-psi commented 1 month ago

I think the time you spend on reviewing the PR is about the same as if you commit it yourself ;-) But if you want it for some other reason I can do it.

Just wanted to encourage to contribute yourself :smile: no other reason

mowies commented 1 month ago

i can do it as well 🤷🏼

mowies commented 1 month ago

@abraxxa @mx-psi PR is open