search

open-telemetry / opentelemetry-collector-releases

OpenTelemetry Collector Official Releases
https://opentelemetry.io
Apache License 2.0
252 stars 162 forks source link

change goreleaser for builder to use GITHUB_TOKEN #707

Closed jackgopack4 closed 1 month ago

jackgopack4 commented 1 month ago

Release was failing as GH_PAT is not a valid secret in open-telemetry/opentelemetry-collector-releases

This is a fix to unblock release of ocb for versions 0.112.0 and beyond.

Please see the sample releases in my fork:

https://github.com/jackgopack4/opentelemetry-collector-releases/actions/runs/11483616588/job/31959465698 https://github.com/jackgopack4/opentelemetry-collector-releases/releases/tag/cmd/builder/v0.112.0 https://github.com/jackgopack4/opentelemetry-collector-releases/pkgs/container/opentelemetry-collector-releases%2Fopentelemetry-collector-builder https://hub.docker.com/layers/johnpeterson785/opentelemetry-collector-builder/0.112.0/images/sha256-6a85c23fe59f516a23ff5627cff1ee3328167f1e3846fa9cd00760af0bdff568?context=explore

We should also consider removing reference to GH_PAT in other workflow files but this is not necessary to unblock v0.112.0 release

evan-bradley commented 1 month ago

Thanks @jackgopack4!