open-telemetry / opentelemetry-collector-releases

OpenTelemetry Collector Official Releases
https://opentelemetry.io
Apache License 2.0
247 stars 160 forks source link

Add Goreleaser templating logic for more distributions (i.e. otelcol-k8s, otelcol-otlp) #716

Open jackgopack4 opened 1 day ago

jackgopack4 commented 1 day ago

currently, only the otelcol and otelcol-contrib goreleaser files are generated via template. There are some differences between these and the k8s and otlp distros; specifically having to do with fewer versions and/or different default files included. Given that our goreleaser templates are run in cmd/goreleaser, there should be some logic to enable generating the k8s and otlp distributions (and any future distributions) with this template. I'm happy to take this on, as it may be necessary to split up goreleaser further to enable buildmode=pie for security in accordance with https://github.com/open-telemetry/opentelemetry-collector-releases/issues/618 and https://github.com/open-telemetry/opentelemetry-collector-releases/issues/693

mx-psi commented 1 day ago

Sounds reasonable to me