search

open-telemetry / opentelemetry-collector

OpenTelemetry Collector
https://opentelemetry.io
Apache License 2.0
3.94k stars 1.32k forks source link

DNS gRPC OTEL exporter endpoing incorrectly sanitised #10017

Closed nmiculinic closed 3 weeks ago

nmiculinic commented 4 weeks ago

Describe the bug

https://github.com/open-telemetry/opentelemetry-collector/blob/v0.97.0/exporter/otlpexporter/config.go

Until v0.96.0 this was fine, and I could do 

endpoint:  dns:host:port

as per spec https://github.com/grpc/grpc/blob/master/doc/naming.md ; however this overly eager sanitisation is killing it.

This is important for fast network failover within gRPC itself; plain old "endpoint" doesn't work that well, and there's increase in send failures

TylerHelmuth commented 4 weeks ago

I suspect this will be fixed when https://github.com/open-telemetry/opentelemetry-collector/pull/10010 is released