SeanPMiller
commented
3 weeks ago As a workaround, I have switched to using the following function:
func temporaryDryRunPatch(settings otelcol.CollectorSettings, ctxt context.Context) (err error) {
factories, err := settings.Factories()
if err != nil {
return fmt.Errorf("failed to initialize factories: %w", err)
}
confProv, err := otelcol.NewConfigProvider(settings.ConfigProviderSettings)
if err != nil {
return fmt.Errorf("failed to instantiate configuration provider: %w", err)
}
defer func() {
if shutdownErr := confProv.Shutdown(ctxt); shutdownErr != nil {
if err != nil {
err = fmt.Errorf("configuration-provider shutdown failed after encountering error: shutdown_err=%w, original_err=%w", shutdownErr, err)
} else {
err = fmt.Errorf("configuration-provider shutdown failed: %w", shutdownErr)
}
}
}()
cfg, err := confProv.Get(ctxt, factories)
if err != nil {
return fmt.Errorf("failed to get config: %w", err)
}
return cfg.Validate()
}This gives me the behavior I want, so this is not an especially high-priority issue.
mx-psi
TylerHelmuth
ycombinator
Describe the bug This behavior might be intended. However, if you write your own entrypoint into the collector, as I have, and you call
otelcol.Collector.DryRun()with a goal of determining whether the configuration "looks valid" before callingRun(), thenservice.New()is now called as part of the dry run, and its return value is discarded. This behavior is a consequence of this commit.Due to the above behavior, calling
DryRun()now, for example, callsopen()andbind()for the self-monitoring telemetry-service port and the health-check extension port, among other ports. WhenRun()is subsequently called, the second instance of each server component fails with abind()error because its port has already been opened and bound.This might be a misuse of the
DryRun()function. Let me know, and thanks in advance.Steps to reproduce Write the above code.
What did you expect to see? The old behavior.
What did you see instead?
What version did you use? v0.98.0
Environment go version go1.22.0 linux/amd64