search

open-telemetry / opentelemetry-collector

OpenTelemetry Collector
https://opentelemetry.io
Apache License 2.0
3.94k stars 1.32k forks source link

[chore] Allow sometimes skipping deprecation process when adding variadic arguments #10041

Closed evan-bradley closed 2 weeks ago

evan-bradley commented 3 weeks ago

Description

Call out that unnamed types, e.g. the function signature of an exported function, should not be relied upon by API consumers. In particular, updating a function to be variadic will break users who were depending on that function's signature.

Link to tracking issue

Helps https://github.com/open-telemetry/opentelemetry-collector/pull/9041

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.87%. Comparing base (aacb835) to head (64ff97b).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #10041 +/- ## ========================================== - Coverage 91.88% 91.87% -0.02% ========================================== Files 360 360 Lines 16725 16725 ========================================== - Hits 15368 15366 -2 - Misses 1020 1021 +1 - Partials 337 338 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

evan-bradley commented 2 weeks ago

Got it, I misunderstood the intent of this section. I've added a section to our contributing document instead.