Bogus service.name used for internal telemetry - Githubissues

open-telemetry / opentelemetry-collector

OpenTelemetry Collector

https://opentelemetry.io

Apache License 2.0

4.25k stars 1.4k forks source link

Bogus service.name used for internal telemetry #10644

Closed yurishkuro closed 1 month ago

yurishkuro commented 1 month ago

Describe the bug

When initializing TracerProvider the BuildInfo.Version is used as a service name.

https://github.com/open-telemetry/opentelemetry-collector/blob/43ed6184f9fedb403ce6eeda02d6eb4d3da94422/service/telemetry/tracer.go#L31

What did you expect to see? Assuming that BuildInfo is the right thing to use in the first place, the reasonable mapping would be

Command -> service.name
Version -> service.version

https://github.com/open-telemetry/opentelemetry-collector/blob/43ed6184f9fedb403ce6eeda02d6eb4d3da94422/component/build_info.go#L22-L24

What version did you use? Version: v0.105.0

mx-psi commented 1 month ago

The proposed change makes sense to me