Open dmitryax opened 2 years ago
As discussed in https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/16533, we will not be moving the attributes to the metrics section in metadata.yaml. So I'm closing the corresponding action item as "Won't do"
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers
. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.
Pinging code owners for cmd/telemetrygen: @mx-psi @amenasria @codeboten. See Adding Labels via Comments if you do not have permissions to add labels yourself.
It's cmd/mdatagen
not telemetrygen :)
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers
. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself.
This issue has been closed as inactive because it has been stale for 120 days with no activity.
Rename sum.aggregation field to not confuse it with attributes_aggregation Rename
sum.aggregation
tosum.aggregation_temporality
? Following https://github.com/open-telemetry/opentelemetry-collector/blob/main/pdata/pmetric/generated_sum.go#L49
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers
. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself.
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers
. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself.
This issue has been closed as inactive because it has been stale for 120 days with no activity.
We need to provide users with the ability to change a set of attributes emitted by a metrics receiver by applying an automatic re-aggregation of the data points. For example,
system.cpu.time
is emitted by default withstate
andcpu
attributes. Many users don't need metrics per CPU core, so they would like to get metrics per host and state instead. Currently, they would need to set up an additional metricstransform processor to achieve that. But this can happen inside the metrics builder instead.Changes to metadata.yaml interface for receiver builders
This will also allow us to introduce the notion of Optional attributes that are disabled by default. E.g. cpu core is a good candidate for that.
This also requires moving the
attributes
section from the top level under each metric removing the naming confusion between the name of an attribute key andvalue
field that not be needed anymore. Receiver authors that don't like the additional repetition can use YAML anchors instead.Additional interface to user configuration
The metrics interface will get additional fields to disable/enable metrics and change the aggregation type. For example:
Action items
Move the attributes section under each metricsum.aggregation
field to not confuse it with attributes_aggregation