search

open-telemetry / opentelemetry-collector

OpenTelemetry Collector
https://opentelemetry.io
Apache License 2.0
4.27k stars 1.41k forks source link

Format generated test code #10899

Open atoulme opened 8 months ago

atoulme commented 8 months ago

Component(s)

cmd/mdatagen

Describe the issue you're reporting

See https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/30425#discussion_r1449111824 and https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/30419#discussion_r1448225840

Generated code is not formatted. We can run gofmt explicitly on the generated code when we generate the test.

github-actions[bot] commented 8 months ago

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

dmitryax commented 8 months ago

My bigger concern is why linter isn't firing for this use case. Submitted https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/30439

crobert-1 commented 8 months ago

Sounds like a good idea to me, and the concern regarding the linter not running has been answered.

github-actions[bot] commented 6 months ago

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

github-actions[bot] commented 3 months ago

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

github-actions[bot] commented 1 month ago

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

codeboten commented 4 weeks ago

transferred issue as mdatagen lives in the core repo now