open-telemetry / opentelemetry-collector

OpenTelemetry Collector
https://opentelemetry.io
Apache License 2.0
4.37k stars 1.45k forks source link

[cmd/mdatagen] Add an option to generate setters from callbacks #10901

Open dmitryax opened 1 year ago

dmitryax commented 1 year ago

Component(s)

No response

Is your feature request related to a problem? Please describe.

To avoid doing unnecessary work fetching data from external sources for disabled metrics or resource attributes. Originally posted by @mx-psi in https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/24360#discussion_r1266593277

Describe the solution you'd like

The control of how to generate the setter can be set in metadata.yaml similar to https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/receiver/apachereceiver/metadata.yaml#L66

Describe alternatives you've considered

No response

Additional context

No response

github-actions[bot] commented 1 year ago

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

github-actions[bot] commented 10 months ago

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

github-actions[bot] commented 8 months ago

This issue has been closed as inactive because it has been stale for 120 days with no activity.

codeboten commented 2 months ago

transferred issue as mdatagen lives in the core repo now