search

open-telemetry / opentelemetry-collector

OpenTelemetry Collector
https://opentelemetry.io
Apache License 2.0
4.43k stars 1.46k forks source link

[CI] Contrib tests should also test updated mdatagen #11167

Open mx-psi opened 1 month ago

mx-psi commented 1 month ago

When we run make update-otel we update the mdatagen version as well. To avoid issues in contrib, we have the contrib tests but they are not testing this.

I believe in order to do this it would be as simple as adding a -replace option on check-contrib here https://github.com/open-telemetry/opentelemetry-collector/blob/5fc39ba6334f396c3b5497bf6d29db12823cb50c/Makefile#L260C1-L260C14 to also replace the version of mdatagen

jade-guiton-dd commented 1 month ago

For fully testing the implications of updating mdatagen, I think it will also be necessary to forcefully rebuild .tools/mdatagen and run make generate in contrib. Adding a matching -dropreplace in the restore-contrib target will also be necessary.

PrateekKumar1709 commented 1 month ago

Hi @mx-psi, I would like to work on this issue. Can you please assign this to me?

mx-psi commented 3 days ago

11519 added an additional check on mdatagen: https://github.com/open-telemetry/opentelemetry-collector/blob/e76145a63a597531dcc7fd109f8cf8c620135cc9/cmd/mdatagen/internal/metadata.go#L55 which did not make CI fail. Reopening this.