open-telemetry / opentelemetry-collector

OpenTelemetry Collector
https://opentelemetry.io
Apache License 2.0
4.29k stars 1.42k forks source link

[mdatagen]: provide mutualised assertions template #11189

Open mmorel-35 opened 1 day ago

mmorel-35 commented 1 day ago

After having done some evolution on mdatagen related with the best practices of testify I’d like to suggest the use of a common function to generate code assertions. It used to be a simple assert.Equal(t, ..., ...) But it’s better to have

This code has to be replicated in several places. It would be nice defining a reusable template so in case of evolution it will be easier to evolve.

mmorel-35 commented 1 day ago

cc @jade-guiton-dd, @mx-psi , @codeboten, @bogdandrutu ,

Related to