The hostmetrics receiver is testing factory.CreateMetricsScraper which returns a scraperhelper.Scraper and is not calling scraperhelper.NewScraperControllerReceiver so scraperhelper.AddScraperWithType isn't an option. To move forward with the release I removed the test's use ofScraper.ID`.
Was this an intended outcome of the change? If so this issue can be closed.
Description
In https://github.com/open-telemetry/opentelemetry-collector/pull/11659
Scraper.IDwas deprecated in favor ofAddScraperWithType. During the v0.114.0 release I found that this was an incompatible switch for the hostmetric receiver's factory tests.The hostmetrics receiver is testing
factory.CreateMetricsScraperwhich returns ascraperhelper.Scraperand is not callingscraperhelper.NewScraperControllerReceiversoscraperhelper.AddScraperWithType isn't an option. To move forward with the release I removed the test's use ofScraper.ID`.Was this an intended outcome of the change? If so this issue can be closed.
Related: https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/36395#discussion_r1846907639