Open dmathieu opened 4 days ago
Attention: Patch coverage is 93.99478%
with 23 lines
in your changes missing coverage. Please review.
Project coverage is 91.53%. Comparing base (
f74890a
) to head (408fbc9
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
Is there any way we can make a graceful transition for avoiding this breakage in contrib?
=== FAIL: . (0.00s)
FAIL github.com/open-telemetry/opentelemetry-collector-contrib/extension/encoding/otlpencodingextension [build failed]
=== Errors
Error: ./extension_test.go:205:6: im.SetStartTime undefined (type pprofile.Profile has no field or method SetStartTime)
Error: ./extension_test.go:206:6: im.SetEndTime undefined (type pprofile.Profile has no field or method SetEndTime)
I can bring back StartTime
, with TimeNanos
as the origin field name. But I can't bring back EndTime
, as Duration
doesn't have the same meaning.
I have made EndTime a noop.
This PR includes https://github.com/open-telemetry/opentelemetry-collector/pull/11706, as the two are very close and separating them would cause weird conflicts.
Should we close #11706 then?
It really depends how reviews go. If you prefer reviewing a single but bigger PR, then yes.
This upgrades pdata to the 1.4.0 version of protobufs.
Sorry for the very large PR. This can't really be split into smaller PRs though, as changes are not backwards compatible.
This PR includes https://github.com/open-telemetry/opentelemetry-collector/pull/11706, as the two are very close and separating them would cause weird conflicts. The two changes can be merged either as separate PRs (with 11706 first), or as one.
Closes https://github.com/open-telemetry/opentelemetry-collector/issues/11720
cc @mx-psi