search

open-telemetry / opentelemetry-collector

OpenTelemetry Collector
https://opentelemetry.io
Apache License 2.0
4.36k stars 1.44k forks source link

Add 3 host metrics and delete vmmetricsreceiver #1240

Closed bogdandrutu closed 4 years ago

bogdandrutu commented 4 years ago

Currently we miss https://github.com/open-telemetry/opentelemetry-collector/blob/master/receiver/vmmetricsreceiver/vm_metrics_constants.go#L63 system/processes/xyz metrics from vmmetricsreceiver and then we can remove the vmmetricsreceiver.

Would be good @james-bebbington if you can fix this soon so we can remove that old code.

james-bebbington commented 4 years ago

Pending https://github.com/shirou/gopsutil/pull/897

bogdandrutu commented 4 years ago

@james-bebbington you can start a PR with the two values that you already have and we can add the third one later.

james-bebbington commented 4 years ago

@bogdandrutu I think you can close this now