Closed james-bebbington closed 4 years ago
Updated plans for this:
pdh.dll
to extract perf counter data. This is useful for getting generic performance counter data, so will move this code to Contrib and create a perf counter receiver that targets Windows only. That receiver will be useful for generating stats on IIS, SQL Server, etc. Tracked in https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/1088.Benefits of (2):
third_party
code from Core 🎉 third_party
code to be accessible from Contrib. Just move it to Contrib instead as part of (1).@james-bebbington are we done with this issue?
There is one comment above about moving the pagefile syscalls to gopsutil which is not done but that is not third party code and not very high priority so yes I think it makes sense to close this issue: all third party code is gone 👍
The Host Metrics receiver currently includes third party code for retrieving windows performance counter info, which is used to calculate load and paging metrics. We also calculate page file usage from a direct syscall into
psapi.dll
.Ideally, we would like to upstream code to gopsutil to calculate these values directly so we can remove this code from the Collector repo.