search

open-telemetry / opentelemetry-collector

OpenTelemetry Collector
https://opentelemetry.io
Apache License 2.0
4.32k stars 1.43k forks source link

add tests for internal metrics emitted via periodic metric reader #9778

Open codeboten opened 6 months ago

codeboten commented 6 months ago

As per @dmitryax's comment, there is insufficient unit test coverage of the telemetry emitted by the collector.

I'm worried that the emitted internal metrics are not covered by tests. It'll be great to see some metrics output changed in tests along with this change. @codeboten, do you know if we have a GH issue to introduce such coverage, by chance?

Originally posted by @dmitryax in https://github.com/open-telemetry/opentelemetry-collector/issues/9775#issuecomment-2000256261

nerudadhich commented 6 months ago

Hi @codeboten, I would like to contribute on this. Would you be able to guide me with below findings ?

Should we add missing cases here in proctelemetry/config_test.go or we need to add more coverage for obsreport.go based on your PR results ?