adding instrumentation configuration

open-telemetry / opentelemetry-configuration

JSON Schema definitions for OpenTelemetry file configuration

Apache License 2.0

41 stars 17 forks source link

adding instrumentation configuration #91

Closed brettmc closed 5 months ago

brettmc commented 6 months ago

Initial draft of adding instrumentation configuration.

added all of the instrumentation-specific examples I found in https://github.com/MrAlias/otel-schema/issues/8
a common property for settings that are common to multiple instrumentations (ie, otel.instrumentation.common.*), and added schema for the ones I know about
a series of language-specific properties, which are deliberately vague

Closes: #87

brettmc commented 6 months ago

Just FYI, I'm going to be offline on vacation for a couple of weeks and won't be able to work on this.

jack-berg commented 6 months ago

Just FYI, I'm going to be offline on vacation for a couple of weeks and won't be able to work on this.

Not sure if you'll see this, but I'd like to pick this up and run with it if you don't mind me pushing some commits to your branch.

brettmc commented 6 months ago

Not sure if you'll see this, but I'd like to pick this up and run with it if you don't mind me pushing some commits to your branch.

No problem at all!

jack-berg commented 6 months ago

How do others feel about keeping the separator consistent using ? I worry that it would make usability more difficult if we support a mix of and -

👍 let's add it to schema modeling rules

jack-berg commented 6 months ago

I pushed a commit to tweak a few things. Have a look folks! If we can get this merged, the next step is to start a conversation about figuring out how instrumentations can actually access this configuration via APIs.

jack-berg commented 5 months ago

@open-telemetry/configuration-maintainers PTAL when you can. Will merge thursday 6/6/24 if there are no additional comments. Thanks!