search

open-telemetry / opentelemetry-cpp-contrib

https://opentelemetry.io/
Apache License 2.0
121 stars 130 forks source link

Fix windows build for Geneva Metrics exporter #276

Closed lalitb closed 1 year ago

lalitb commented 1 year ago

The windows build breaks with error:

  unix_domain_socket_data_transport.cc
C:\Users\labhas\Obs\otel\lalit\opentelemetry-cpp-contrib\exporters\geneva\include\opentelemetry/exporters/geneva/metrics/socket_tools.h(319,21): e
rror C2065: 'sa_family_t': undeclared identifier [C:\Users\labhas\Obs\otel\lalit\opentelemetry-cpp-contrib\exporters\geneva\build\opentelemetry_ex
porter_geneva_metrics.vcxproj]

sa_family_t was introduced as part of abstract_socket support, and that is breaking the windows build. Fixing it here.

Also we need to add Windows CI build here to catch these errors. Will do it as separate PR.