What?
The fluentd exporter lacks breaking changes around the naming of Log classes (which changed to LogRecord classes).
Remove -DWITH_fluentd option that seems deprecated now.
What will this enable?
This should enable adding opentelemetry-fluentd to vcpkg, since the opentelemetry-fluentd port depends on opentelemetry, so we need to be compilation-compatible with the latest version, which is 1.9.1.
What validation have I run?
I've been able to see my changes in my own fluentd server:
What? The fluentd exporter lacks breaking changes around the naming of Log classes (which changed to LogRecord classes).
Remove -DWITH_fluentd option that seems deprecated now.
What will this enable? This should enable adding opentelemetry-fluentd to vcpkg, since the opentelemetry-fluentd port depends on opentelemetry, so we need to be compilation-compatible with the latest version, which is 1.9.1.
What validation have I run? I've been able to see my changes in my own fluentd server:
023-06-20 19:46:35.296130644 +0000 Log: {"ObservedTimestamp":1687290395,"Timestamp":null,"body":"f2","severityNumber":5,"severityText":"DEBUG"} 2023-06-20 19:46:35.296328136 +0000 Log: {"ObservedTimestamp":1687290395,"Timestamp":null,"body":"f3","severityNumber":5,"severityText":"DEBUG"}
I've also passed the gtests:![image](https://github.com/open-telemetry/opentelemetry-cpp-contrib/assets/105019436/578a5115-9dad-4724-9681-14c061f525fb)
I also repeated the build and gtest-suite on a fresh Ubuntu-20.04 VM.