[Logs SDK] Log Appender for Boost.Log

open-telemetry / opentelemetry-cpp-contrib

https://opentelemetry.io/

Apache License 2.0

121 stars 129 forks source link

[Logs SDK] Log Appender for Boost.Log #359

Closed chusitoo closed 4 months ago

chusitoo commented 5 months ago

Implemented as described in https://github.com/open-telemetry/opentelemetry-cpp/issues/2048:

Sink backend allows for mapping customizations to account for the extensive flexibility that boost sinks already provide.
Minimal examples provided to demonstrate the setup required.
Basic unit testing.
Tried using the same flags as those used in otel-cpp for configuring cmake project.
Add clang format file to help keep the style in line with otel-cpp repo.

lalitb commented 4 months ago

@chusitoo thank you for your contributions. Would it be fine to add you as the owner of these appender components? This would entail overseeing any pull requests, approvals, and merges for these components.

https://github.com/open-telemetry/opentelemetry-cpp-contrib/blob/main/.github/CODEOWNERS

lalitb commented 4 months ago

LGTM in general. Good to add CI for these appenders as separate PR to ensure everything builds and runs fine.

chusitoo commented 4 months ago

@chusitoo thank you for your contributions. Would it be fine to add you as the owner of these appender components? This would entail overseeing any pull requests, approvals, and merges for these components.

https://github.com/open-telemetry/opentelemetry-cpp-contrib/blob/main/.github/CODEOWNERS

Thanks for the review @lalitb. Sure, I can take care of overseeing request, changes and/or additions to log appenders. Appreciate the offering.