open-telemetry / opentelemetry-cpp-contrib

https://opentelemetry.io/

Apache License 2.0

121 stars 128 forks source link

[Geneva, User Events] Update CMakeLists.txt #408

Closed Pravila00 closed 2 months ago

Pravila00 commented 3 months ago

Changes

Rename BUILD_EXAMPLE to WITH_EXAMPLES to be consistent with opentelemetry-cpp repository.
Add option to skip the build of Tracepoints library. This will be used for Vcpkg build, as we will set Tracepoint library as a dependency of the feature.
Replace usage of CMAKE_CXX_STANDARD by target_compile_features.

linux-foundation-easycla[bot] commented 3 months ago

The committers listed above are authorized under a signed CLA.

:white_check_mark: login: Pravila00 / name: Pravila (9dc0acb25584bcdfc38e3eb6a3470b2fccd74a03, 4e113677d5c5168438dbd607c4345adf479dcda0)

Pravila00 commented 2 months ago

I've just modified my commit history for using only this GitHub account where I have CLA access, we should be good now :) Would you mind checking if everything is still okay @lalitb? Thanks for the review!