[CI] Add CI for instrumentation/log4cxx

open-telemetry / opentelemetry-cpp-contrib

https://opentelemetry.io/

Apache License 2.0

121 stars 128 forks source link

[CI] Add CI for instrumentation/log4cxx #426

Closed marcalff closed 2 months ago

marcalff commented 2 months ago

Fixes #422

Fixed CMakeLists:

Require GTest 1.12.0. Building with 1.11 breaks the build due to a gtest bug.

Fixed link issue:

Moved IMPLEMENT_LOG4CXX_OBJECT(OpenTelemetryAppender) from header to implementation

marcalff commented 2 months ago

@chusitoo FYI

chusitoo commented 2 months ago

@chusitoo FYI

Thanks @marcalff, one thing that I notice is that CTest is not being run in the actions.

This is due to an overlook on my part, as I've always run the UTs executable manually. The fix is simple enough, though, but affects all log appenders equally:

if(BUILD_TESTING)
  enable_testing()