search

open-telemetry / opentelemetry-cpp-contrib

https://opentelemetry.io/
Apache License 2.0
121 stars 128 forks source link

[CI] Upgrade otel-webserver-module CI to opentelemetry-cpp 1.15.0 #433

Open marcalff opened 2 months ago

marcalff commented 2 months ago

Upgrade otel-webserver-module CI to opentelemetry-cpp 1.15.0.

If possible, please use semantic conventions from opentelemetry-cpp, instead of local constants such as:

const std::string kServiceName = "service.name";

as found in SdkConstants.h.

See opentelemetry-cpp header file opentelemetry/sdk/resource/semantic_conventions.h

https://github.com/open-telemetry/opentelemetry-cpp/blob/main/sdk/include/opentelemetry/sdk/resource/semantic_conventions.h

aryanishan1001 commented 2 months ago

I will look into it and make the required changes.