search

open-telemetry / opentelemetry-cpp-contrib

https://opentelemetry.io/
Apache License 2.0
125 stars 140 forks source link

fluentd exporter: Add support for DNS name lookup #468

Closed justin-mccann closed 3 months ago

justin-mccann commented 4 months ago

Add support for DNS lookups using getaddrinfo(3). The API supports lookups of hostnames, IPv4, or IPv6 addresses.

This uses the first AF_INET or AF_INET6 address returned from the list and fails if none is available.

A followup PR triggers new lookups on socket failure.

ThomsonTan commented 3 months ago

@justin-mccann could you please take a look at the comments from @lalitb ?

justin-mccann commented 3 months ago

@justin-mccann could you please take a look at the comments from @lalitb ?

Done; thanks for the reminder, and sorry it was needed.