Closed sirzooro closed 2 years ago
Thanks, this problem is already fixed by #1413
I ran the "steps to reproduce" on your owent-contrib:merge_async-changes_into_main branch and I still get the "Missing value for flag: --experimental_allow_proto3_optional" error. How does #1413 fix this issue?
--experimental_allow_proto3_optional
flag is supported with protoc version 3.12.0, and optional after 3.15.0. I don't think it will work with earlier versions. This seems to be an issue for the distro like CentOS8/Redhat8 which comes with older protoc compiler.
@sirzooro, @javaccar - Can you upgrade the protoc? I don't see any other solution for now, as metrics proto files uses optional
fields. This needs to be driven further with otel-proto repo owners.
I ran the "steps to reproduce" on your owent-contrib:merge_async-changes_into_main branch and I still get the "Missing value for flag: --experimental_allow_proto3_optional" error. How does #1413 fix this issue?
Sorry for my mistake, It's #1383 which solve this problem, it just add --experimental_allow_proto3_optional
.
--experimental_allow_proto3_optional
flag is supported with protoc version 3.12.0, and optional after 3.15.0. I don't think it will work with earlier versions. This seems to be an issue for the distro like CentOS8/Redhat8 which comes with older protoc compiler.
The minimal version of gRPC we support is 1.33.0, which require protobuf 3.13.So I think all versions of protobuf we support have --experimental_allow_proto3_optional
, and it's already added in #1383 .
@owent - I think the with the build option -DWITH_OTLP=ON -DWITH_OTLP_GRPC=OFF
, users have the flexibility to try the older version of protoc compiler(outside of gRPC). But either way - with or without gRPC - protoc version needs to be newer to build metrics proto files.
Sorry for closing it incorrectly :)
@owent - I think the with the build option
-DWITH_OTLP=ON -DWITH_OTLP_GRPC=OFF
, users have the flexibility to try the older version of protoc compiler(outside of gRPC). But either way - with or without gRPC - protoc version needs to be newer to build metrics proto files.
OK, I can raise another PR to add --experimental_allow_proto3_optional
only with protobuf >= 3.12
@sirzooro, @javaccar - Can you upgrade the protoc? I don't see any other solution for now, as metrics proto files uses
optional
fields. This needs to be driven further with otel-proto repo owners.
I can use new version. I would have to switch to it anyway to use OTLP metrics when you release GA version.
OK, I can raise another PR to add --experimental_allow_proto3_optional only with protobuf >= 3.12
I don't think lower protobuf version needs to be supported, as metrics proto files won't compile with that.
Closing the bug, please reopen if there are any further issues, or any change expected here.
Describe your environment CentOS 8 Stream protobuf-3.5.0-15 gcc 10.3.1 cmake 3.20.2 Latest OpenTelemetry CPP source (removed and cloned repo today)
Steps to reproduce
What is the expected behavior? Build completes successfully.
What is the actual behavior?