Closed liadavid closed 10 months ago
SpanProcessor interface accepts Recordable. Following the interface, should TraceZSpanProcessor accept Recordable as well? If yes, can we add getter functions to the Recordable interface?
No, we don't want to add getters to the Recordable
interface and force every vendor to implement it. You can either:
SpanData
. It derives from Recordable
and has getters. You can then cast from Recordable
to SpanData
in the processor.Recordable
and implementing getters. You can then cast from Recordable
to your derived class in the processor.SpanProcessor interface accepts Recordable. Following the interface, should TraceZSpanProcessor accept Recordable as well? If yes, can we add getter functions to the Recordable interface?
No, we don't want to add getters to the
Recordable
interface and force every vendor to implement it. You can either:
- Use the existing
SpanData
. It derives fromRecordable
and has getters. You can then cast fromRecordable
toSpanData
in the processor.- Implement your own class deriving from
Recordable
and implementing getters. You can then cast fromRecordable
to your derived class in the processor.
Thanks Johannes for the explanation regarding Recordable.
This issue was marked as stale due to lack of activity. It will be closed in 7 days if no furthur activity occurs.
Closed as inactive. Feel free to reopen if this is still an issue.
This issue was marked as stale due to lack of activity. It will be closed in 7 days if no furthur activity occurs.
Closed as inactive. Feel free to reopen if this is still an issue.
Closing, as zpages is removed, see #2292
Is your feature request related to a problem?
ZPages are web-pages that display general and debugging information on processes. Tracez provides details about the trace spans in the process. Currently there are few WIP projects to add zPages to OpenTelemetry, following the zPages spec/general direction. We would like to add a Tracez zPage to the OpenTelemetry-CPP package.
Describe the solution you'd like
The tracez page should include:
Scope and requirements:
High level design TraceZ architecture is divided into the following components:
Describe alternatives you've considered
Both alternatives are good extensions for the MVP defined above. Another possible extension is to add a Tracez Sampler component that will enable the developer to determine the sampling ratio of traces shown/aggregated in TraceZ.
Additional context
README
Open Questions