open-telemetry / opentelemetry-cpp

The OpenTelemetry C++ Client
https://opentelemetry.io/
Apache License 2.0
860 stars 410 forks source link

::variant documentation is not clear enough #2539

Open orion160 opened 8 months ago

orion160 commented 8 months ago

Uses Abseil C++ Library for absl::variant as default nostd::variant if WITH_ABSEIL cmake option or --@io_opentelemetry_cpp//api:with_abseil=true (aka --//api:with_abseil=true) bazel option is enabled. License: Apache License 2.0

https://github.com/open-telemetry/opentelemetry-cpp/blob/main/docs/dependencies.md

orion160 commented 8 months ago

Key points:

WITH_ABSEIL uses nostd::variant or absl::variant?

Are WITH_STL and WITH_ABSL exclusive?

github-actions[bot] commented 8 months ago

This issue is available for anyone to work on. Make sure to reference this issue in your pull request. :sparkles: Thank you for your contribution! :sparkles:

github-actions[bot] commented 6 months ago

This issue was marked as stale due to lack of activity.

Annosha commented 4 days ago

Hi @orion160, is this issue beginner friendly? I don't have a very deep understanding of C++ but would like to contribute if it isn't very complex to work on. TIA