open-telemetry / opentelemetry-cpp

The OpenTelemetry C++ Client
https://opentelemetry.io/
Apache License 2.0
817 stars 392 forks source link

[bazel] Move -std=c++14 to .bazelrc #2600

Closed keith closed 3 months ago

keith commented 3 months ago

This way it applies to local builds as well as CI builds

Related: https://github.com/open-telemetry/opentelemetry-cpp/pull/2599#issuecomment-2013188043

keith commented 3 months ago

thanks!

marcalff commented 3 months ago

This now causes the folloging message in build logs, for bazel windows:

cl : Command line warning D9002 : ignoring unknown option '-std=c++14'
keith commented 3 months ago

oops, thanks! https://github.com/open-telemetry/opentelemetry-cpp/pull/2601