open-telemetry / opentelemetry-cpp

The OpenTelemetry C++ Client
https://opentelemetry.io/
Apache License 2.0
850 stars 403 forks source link

[bazel] Enable --incompatible_disallow_empty_glob #2642

Open keith opened 5 months ago

keith commented 5 months ago

This way downstream consumers can enable this flag as well

malkia commented 5 months ago

I have a list in my soft fork, with few more incompatbiles that were enabled (whatever I can) - https://github.com/malkia/opentelemetry-cpp/blob/main/.bazelrc#L92 - although that specifically did not work - I think it was for the prometheus-cpp module?

keith commented 4 months ago

depends on https://github.com/jupp0r/prometheus-cpp/pull/715 and probably some other stuff

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.68%. Comparing base (497eaf4) to head (46f37c7). Report is 115 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/open-telemetry/opentelemetry-cpp/pull/2642/graphs/tree.svg?width=650&height=150&src=pr&token=FJESTYQ2AD&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)](https://app.codecov.io/gh/open-telemetry/opentelemetry-cpp/pull/2642?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) ```diff @@ Coverage Diff @@ ## main #2642 +/- ## ========================================== + Coverage 87.12% 87.68% +0.56% ========================================== Files 200 190 -10 Lines 6109 5851 -258 ========================================== - Hits 5322 5130 -192 + Misses 787 721 -66 ``` [see 78 files with indirect coverage changes](https://app.codecov.io/gh/open-telemetry/opentelemetry-cpp/pull/2642/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)
marcalff commented 3 months ago

depends on jupp0r/prometheus-cpp#715 and probably some other stuff

This PR in prometheus-cpp:

is merged, but there is no release yet that includes it.

Opentelemetry-cpp is using the prometheus-cpp 1.2.4 tag.

Waiting on release 1.2.5 from prometheus (adding blocked tag)