search

open-telemetry / opentelemetry-cpp

The OpenTelemetry C++ Client
https://opentelemetry.io/
Apache License 2.0
815 stars 391 forks source link

`nostd::enable_if_t` should be used instead of `std::enable_if_t` #2647

Closed owent closed 2 months ago

owent commented 2 months ago

Describe your environment

Linux+GCC 4.8

What is the expected behavior? Build success

What is the actual behavior?

cd /home/runner/work/cmake-toolset/cmake-toolset/test/build_jobs_dir/_deps/opentelemetry_cpp-v1.15.0/linux-x86_64-gnu/sdk/src/trace && /usr/bin/g++-4.8 -DENABLE_ASYNC_EXPORT -DENABLE_METRICS_EXEMPLAR_PREVIEW -DHAVE_ABSEIL -DOPENTELEMETRY_ABI_VERSION_NO=1 -D__CLANG_SUPPORT_DYN_ANNOTATION__ -I/home/runner/work/cmake-toolset/cmake-toolset/test/build_jobs_dir/_deps/opentelemetry_cpp-v1.15.0/linux-x86_64-gnu/generated/third_party/opentelemetry-proto -I/home/runner/work/cmake-toolset/cmake-toolset/test/third_party/packages/opentelemetry-cpp-v1.15.0/api/include -I/home/runner/work/cmake-toolset/cmake-toolset/test/third_party/packages/opentelemetry-cpp-v1.15.0/sdk/include -I/home/runner/work/cmake-toolset/cmake-toolset/test/third_party/packages/opentelemetry-cpp-v1.15.0/sdk -I/home/runner/work/cmake-toolset/cmake-toolset/test/third_party/packages/opentelemetry-cpp-v1.15.0/ext/include -isystem /home/runner/work/cmake-toolset/cmake-toolset/test/third_party/install/linux-x86_64-gnu/include -fexceptions -frtti -pthread -O2 -g -DNDEBUG -ggdb -std=gnu++1y -fPIC -Wno-error=deprecated-declarations -MD -MT sdk/src/trace/CMakeFiles/opentelemetry_trace.dir/tracer_context.cc.o -MF CMakeFiles/opentelemetry_trace.dir/tracer_context.cc.o.d -o CMakeFiles/opentelemetry_trace.dir/tracer_context.cc.o -c /home/runner/work/cmake-toolset/cmake-toolset/test/third_party/packages/opentelemetry-cpp-v1.15.0/sdk/src/trace/tracer_context.cc
In file included from /home/runner/work/cmake-toolset/cmake-toolset/test/third_party/packages/opentelemetry-cpp-v1.15.0/sdk/include/opentelemetry/sdk/trace/recordable.h:12:0,
                 from /home/runner/work/cmake-toolset/cmake-toolset/test/third_party/packages/opentelemetry-cpp-v1.15.0/sdk/include/opentelemetry/sdk/trace/multi_recordable.h:10,
                 from /home/runner/work/cmake-toolset/cmake-toolset/test/third_party/packages/opentelemetry-cpp-v1.15.0/sdk/include/opentelemetry/sdk/trace/multi_span_processor.h:11,
                 from /home/runner/work/cmake-toolset/cmake-toolset/test/third_party/packages/opentelemetry-cpp-v1.15.0/sdk/src/trace/tracer_context.cc:5:
/home/runner/work/cmake-toolset/cmake-toolset/test/third_party/packages/opentelemetry-cpp-v1.15.0/sdk/include/opentelemetry/sdk/instrumentationscope/instrumentation_scope.h:76:12: error: ‘std::enable_if_t’ has not been declared
       std::enable_if_t<opentelemetry::common::detail::is_key_value_iterable<ArgumentType>::value>
            ^
/home/runner/work/cmake-toolset/cmake-toolset/test/third_party/packages/opentelemetry-cpp-v1.15.0/sdk/include/opentelemetry/sdk/instrumentationscope/instrumentation_scope.h:76:23: error: expected ‘>’ before ‘<’ token
       std::enable_if_t<opentelemetry::common::detail::is_key_value_iterable<ArgumentType>::value>
                       ^
make[2]: *** [sdk/src/trace/CMakeFiles/opentelemetry_trace.dir/build.make:76: sdk/src/trace/CMakeFiles/opentelemetry_trace.dir/tracer_context.cc.o] Error 1
make[2]: Leaving directory '/home/runner/work/cmake-toolset/cmake-toolset/test/build_jobs_dir/_deps/opentelemetry_cpp-v1.15.0/linux-x86_64-gnu'
make[1]: *** [CMakeFiles/Makefile2:543: sdk/src/trace/CMakeFiles/opentelemetry_trace.dir/all] Error 2
make: *** [Makefile:136: all] Error 2
make[1]: Leaving directory '/home/runner/work/cmake-toolset/cmake-toolset/test/build_jobs_dir/_deps/opentelemetry_cpp-v1.15.0/linux-x86_64-gnu'