[BUILD] Use `nostd::enable_if_t` instead of `std::enable_if_t`

open-telemetry / opentelemetry-cpp

The OpenTelemetry C++ Client

https://opentelemetry.io/

Apache License 2.0

815 stars 391 forks source link

Closed owent closed 2 months ago

owent commented 2 months ago

Fixes #2647

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

owent commented 2 months ago

The failed job report error when compiling upb, which seems not a problem of this PR?

lalitb commented 2 months ago

The failed job report error when compiling upb, which seems not a problem of this PR?

Looks like we need to upgrade com_google_absl. Probably something changed in macos-latest (clang version?) recently which triggered this.

marcalff commented 2 months ago

This PR looks ok.

The build failure on MacOS seems unrelated, and to fix separately.

ThomsonTan commented 2 months ago

This PR looks ok.

The build failure on MacOS seems unrelated, and to fix separately.

Curious on what triggered the MacOS build warning.

lalitb commented 2 months ago

Curious on what triggered the MacOS build warning.

My guess is that XCode update on mac-os14 (which is macos-latest) triggered clang to get updated too.