open-telemetry / opentelemetry-cpp

The OpenTelemetry C++ Client
https://opentelemetry.io/
Apache License 2.0
815 stars 391 forks source link

[BUILD] Upgrade bazel abseil from 20220623.1 to 20230802.2 #2650

Closed marcalff closed 2 months ago

marcalff commented 2 months ago

Fixes # (issue)

Context

Recently, the CI in github upgraded the MacOS runners from version 2.315.0 to 2.316.0.

Before: https://github.com/actions/runner-images/blob/macOS-12/20240412.2/images/macos/macos-12-Readme.md

After: https://github.com/actions/runner-images/blob/macos-14-arm64/20240422.3/images/macos/macos-14-arm64-Readme.md

This broke the build, due to errors related to C++ traits in abseil headers.

Because the MacOS build is flagged as required, this issue actually is critical, because it prevents to merge any PR.

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

lalitb commented 2 months ago

Thanks, so upgrading to anything greater than abseil-cpp-20230802.2 breaks the build ?

marcalff commented 2 months ago

Thanks, so upgrading to anything greater than abseil-cpp-20230802.2 breaks the build ?

Yes, but in a different way.

It breaks because abseil type traits conflicts with std, this probably is an issue with the C++ standard used and WITH_STL.

To resolve separately with #2619.