Closed t-b closed 3 months ago
Sorry, removing the approval for the CI failure. Probably we should set the policy only if vcpkg is used (i.e, VCPKG_TOOLCHAIN is set)? cc @ThomsonTan
My usecase is not related to vcpkg, I'm just compiling with MSVC.
Thanks for the PR.
This change is probably not sufficient, as it triggers build failures in CI.
Please investigate and fix errors such as:
benchmark.lib(benchmark.cc.obj) : error LNK2038: mismatch detected for 'RuntimeLibrary': value 'MDd_DynamicDebug' doesn't match value 'MTd_StaticDebug' in attributes_hashmap_benchmark.obj [D:\a\opentelemetry-cpp\opentelemetry-cpp\build\sdk\test\metrics\attributes_hashmap_benchmark.vcxproj]
Thanks for the review, will do.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 87.68%. Comparing base (
497eaf4
) to head (3ff8b97
). Report is 76 commits behind head on main.:exclamation: Current head 3ff8b97 differs from pull request most recent head 2566fa7
Please upload reports for the commit 2566fa7 to get more accurate results.
The CI should have been fixed by https://github.com/open-telemetry/opentelemetry-cpp/pull/2696.
The documentation for CMAKE_MSVC_RUNTIME_LIBRARY states 1:
so the current usage of CMAKE_MSVC_RUNTIME_LIBRARY for vcpkg does not work at all.
Let's fix that by setting policy 91 to new if present.