Closed marcalff closed 4 months ago
Attention: Patch coverage is 30.00000%
with 7 lines
in your changes are missing coverage. Please review.
Project coverage is 87.68%. Comparing base (
497eaf4
) to head (79595f5
). Report is 72 commits behind head on main.
Good catch :)
Waiting for the build to finish to make sure DLL links, then this will be ready for review.
Add help-wanted label:
The windows DLL build fails with undefined symbols, and I can not figure out why (I don't have windows locally to investigate).
Fixes #2506
Changes
Please provide a brief description of the changes here.
Flush()
andClose()
from theAPI
classopentelemetry::trace::Tracer
, starting with ABI version 2.XXXProviderFactory::Create()
methods to return anSDK
object instead of anAPI
object.Flush()
andShutdown()
.static_cast<SDK*>(API object)
from examples, and use cleaner code, to initialize SDK providers.For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes