open-telemetry / opentelemetry-cpp

The OpenTelemetry C++ Client
https://opentelemetry.io/
Apache License 2.0
815 stars 391 forks source link

[BUILD] Remove the hard-coded separator in tracestate #2672

Closed ThomsonTan closed 1 month ago

ThomsonTan commented 1 month ago

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.59%. Comparing base (497eaf4) to head (74cd28e). Report is 64 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/open-telemetry/opentelemetry-cpp/pull/2672/graphs/tree.svg?width=650&height=150&src=pr&token=FJESTYQ2AD&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)](https://app.codecov.io/gh/open-telemetry/opentelemetry-cpp/pull/2672?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) ```diff @@ Coverage Diff @@ ## main #2672 +/- ## ========================================== + Coverage 87.12% 87.59% +0.47% ========================================== Files 200 188 -12 Lines 6109 5847 -262 ========================================== - Hits 5322 5121 -201 + Misses 787 726 -61 ``` | [Files](https://app.codecov.io/gh/open-telemetry/opentelemetry-cpp/pull/2672?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | Coverage Δ | | |---|---|---| | [api/include/opentelemetry/trace/trace\_state.h](https://app.codecov.io/gh/open-telemetry/opentelemetry-cpp/pull/2672?src=pr&el=tree&filepath=api%2Finclude%2Fopentelemetry%2Ftrace%2Ftrace_state.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-YXBpL2luY2x1ZGUvb3BlbnRlbGVtZXRyeS90cmFjZS90cmFjZV9zdGF0ZS5o) | `97.60% <100.00%> (ø)` | | ... and [57 files with indirect coverage changes](https://app.codecov.io/gh/open-telemetry/opentelemetry-cpp/pull/2672/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)