open-telemetry / opentelemetry-cpp

The OpenTelemetry C++ Client
https://opentelemetry.io/
Apache License 2.0
811 stars 391 forks source link

[BUILD] Read default proto version from `third_party_release` #2677

Closed owent closed 1 month ago

owent commented 1 month ago

Fixes #2676

Changes

For significant contributions please make sure you have completed the following items:

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.70%. Comparing base (497eaf4) to head (4d6b314). Report is 67 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/open-telemetry/opentelemetry-cpp/pull/2677/graphs/tree.svg?width=650&height=150&src=pr&token=FJESTYQ2AD&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)](https://app.codecov.io/gh/open-telemetry/opentelemetry-cpp/pull/2677?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) ```diff @@ Coverage Diff @@ ## main #2677 +/- ## ========================================== + Coverage 87.12% 87.70% +0.58% ========================================== Files 200 190 -10 Lines 6109 5852 -257 ========================================== - Hits 5322 5132 -190 + Misses 787 720 -67 ``` [see 57 files with indirect coverage changes](https://app.codecov.io/gh/open-telemetry/opentelemetry-cpp/pull/2677/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)
owent commented 1 month ago

Thanks for the fix.

See suggested change.

Not sure why opentelemetry-proto.cmake was not formatted in my previous change, as CI was ok on format.

Maybe we should use cmake-format -i $($FIND -name 'CMakeLists.txt' -print -o -name '*.cmake' -print -o -name '*.cmake.in' -print) in tools/format.sh. (Add -o between rules.)