search

open-telemetry / opentelemetry-cpp

The OpenTelemetry C++ Client
https://opentelemetry.io/
Apache License 2.0
810 stars 391 forks source link

[BUILD] Remove the incorrect set of CMAKE_MSVC_RUNTIME_LIBRARY for vcpkg #2696

Closed ThomsonTan closed 3 weeks ago

ThomsonTan commented 3 weeks ago

Changes

VCPKG_LIBRARY_LINKAGE should only be visible to triplet file, not he cmake file using vcpkg as toolchain. So the setting of CMAKE_MSVC_RUNTIME_LIBRARY is incorrect with VCPKG_LIBRARY_LINKAGE referenced in the generator expression. It will always be "" (empty) instead of the expected "static" or "dynamic".

For significant contributions please make sure you have completed the following items:

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.68%. Comparing base (497eaf4) to head (3778e3f). Report is 75 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/open-telemetry/opentelemetry-cpp/pull/2696/graphs/tree.svg?width=650&height=150&src=pr&token=FJESTYQ2AD&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)](https://app.codecov.io/gh/open-telemetry/opentelemetry-cpp/pull/2696?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) ```diff @@ Coverage Diff @@ ## main #2696 +/- ## ========================================== + Coverage 87.12% 87.68% +0.56% ========================================== Files 200 190 -10 Lines 6109 5851 -258 ========================================== - Hits 5322 5130 -192 + Misses 787 721 -66 ``` [see 74 files with indirect coverage changes](https://app.codecov.io/gh/open-telemetry/opentelemetry-cpp/pull/2696/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)
ThomsonTan commented 3 weeks ago

@owent FYI. Feel free to let me know if anything is missing.