Closed dbolduc closed 2 weeks ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 87.67%. Comparing base (
497eaf4
) to head (cbceed1
). Report is 82 commits behind head on main.
@keith Please take a look and comment.
I assume keeping a unused flag is ok.
Keeping and marking deprecated is definitely on. It might be a bit misleading if folks expect it to do something but I definitely understand the issue.
A follow up to #2679.
This
bool_flag
was a part of the public API. If we remove it, anyone using it in downstream code have broken build commands.So instead of removing it, I think we should mark it as deprecated.
On removing the now useless flag...
I do not know what OpenTelemetry's breaking change policy is. But consider something like:
v2.x
). That is Google's policy (don't laugh).In my own repo, I would typically open a new issue and tag the code so we remember to clean it up later.
I am happy to do that here. You will have to tell me when you want to remove it. (If I have convinced y'all to take this PR).