search

open-telemetry / opentelemetry-cpp

The OpenTelemetry C++ Client
https://opentelemetry.io/
Apache License 2.0
811 stars 391 forks source link

[REMOVAL] Remove build option `WITH_DEPRECATED_SDK_FACTORY` #2717

Open marcalff opened 5 days ago

marcalff commented 5 days ago

Fixes #2716

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

codecov[bot] commented 5 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.67%. Comparing base (497eaf4) to head (06f4a24). Report is 94 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/open-telemetry/opentelemetry-cpp/pull/2717/graphs/tree.svg?width=650&height=150&src=pr&token=FJESTYQ2AD&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)](https://app.codecov.io/gh/open-telemetry/opentelemetry-cpp/pull/2717?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) ```diff @@ Coverage Diff @@ ## main #2717 +/- ## ========================================== + Coverage 87.12% 87.67% +0.56% ========================================== Files 200 190 -10 Lines 6109 5855 -254 ========================================== - Hits 5322 5133 -189 + Misses 787 722 -65 ``` | [Files](https://app.codecov.io/gh/open-telemetry/opentelemetry-cpp/pull/2717?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | Coverage Δ | | |---|---|---| | [sdk/src/logs/event\_logger\_provider\_factory.cc](https://app.codecov.io/gh/open-telemetry/opentelemetry-cpp/pull/2717?src=pr&el=tree&filepath=sdk%2Fsrc%2Flogs%2Fevent_logger_provider_factory.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c2RrL3NyYy9sb2dzL2V2ZW50X2xvZ2dlcl9wcm92aWRlcl9mYWN0b3J5LmNj) | `100.00% <ø> (ø)` | | | [sdk/src/trace/tracer\_provider\_factory.cc](https://app.codecov.io/gh/open-telemetry/opentelemetry-cpp/pull/2717?src=pr&el=tree&filepath=sdk%2Fsrc%2Ftrace%2Ftracer_provider_factory.cc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-c2RrL3NyYy90cmFjZS90cmFjZXJfcHJvdmlkZXJfZmFjdG9yeS5jYw==) | `44.83% <ø> (+0.39%)` | :arrow_up: | ... and [105 files with indirect coverage changes](https://app.codecov.io/gh/open-telemetry/opentelemetry-cpp/pull/2717/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)
marcalff commented 5 days ago

Please review.

I suggest to wait at one or two weeks for possible comments on this (the removal issue is pinned), before merging to main.