search

open-telemetry / opentelemetry-cpp

The OpenTelemetry C++ Client
https://opentelemetry.io/
Apache License 2.0
817 stars 392 forks source link

[EXPORTER] Fix references in AttributeValueVisitor #2985

Closed meastp closed 18 hours ago

meastp commented 4 days ago

Just a small fix - I think the correct fix is void operator()(nostd::string_view &&arg) (i.e. without const), at least if it was intended to overload the forwarding reference function above . Might also need void operator()(const nostd::string_view &arg) if both variants should be covered.

codecov[bot] commented 4 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.67%. Comparing base (497eaf4) to head (f06d14b). Report is 96 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/open-telemetry/opentelemetry-cpp/pull/2985/graphs/tree.svg?width=650&height=150&src=pr&token=FJESTYQ2AD&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)](https://app.codecov.io/gh/open-telemetry/opentelemetry-cpp/pull/2985?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) ```diff @@ Coverage Diff @@ ## main #2985 +/- ## ========================================== + Coverage 87.12% 87.67% +0.56% ========================================== Files 200 190 -10 Lines 6109 5855 -254 ========================================== - Hits 5322 5133 -189 + Misses 787 722 -65 ``` | [Files](https://app.codecov.io/gh/open-telemetry/opentelemetry-cpp/pull/2985?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | Coverage Δ | | |---|---|---| | [...ude/opentelemetry/exporters/ostream/common\_utils.h](https://app.codecov.io/gh/open-telemetry/opentelemetry-cpp/pull/2985?src=pr&el=tree&filepath=exporters%2Fostream%2Finclude%2Fopentelemetry%2Fexporters%2Fostream%2Fcommon_utils.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-ZXhwb3J0ZXJzL29zdHJlYW0vaW5jbHVkZS9vcGVudGVsZW1ldHJ5L2V4cG9ydGVycy9vc3RyZWFtL2NvbW1vbl91dGlscy5o) | `100.00% <ø> (ø)` | | ... and [109 files with indirect coverage changes](https://app.codecov.io/gh/open-telemetry/opentelemetry-cpp/pull/2985/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)