open-telemetry / opentelemetry-cpp

The OpenTelemetry C++ Client
https://opentelemetry.io/
Apache License 2.0
851 stars 403 forks source link

[TEST] Fix opentelemetry-collector bind address #2989

Closed marcalff closed 3 months ago

marcalff commented 3 months ago

Changes

Please provide a brief description of the changes here.

The opentelemetry-collector release v1.11.0/v0.104.0 contains a breaking change:

The otlpreceiver now uses localhost by default instead of 0.0.0.0. This may break the receiver in containerized environments like Kubernetes. If you depend on 0.0.0.0 disable the component.UseLocalHostAsDefaultHost feature gate or explicitly set the endpoint to 0.0.0.0.

This broke the functional tests in CI.

Adjust the opentelemetry-collector configuration files used in functional tests to set explicitly an endpoint.

For significant contributions please make sure you have completed the following items:

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.67%. Comparing base (497eaf4) to head (96ec4e5). Report is 95 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/open-telemetry/opentelemetry-cpp/pull/2989/graphs/tree.svg?width=650&height=150&src=pr&token=FJESTYQ2AD&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)](https://app.codecov.io/gh/open-telemetry/opentelemetry-cpp/pull/2989?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) ```diff @@ Coverage Diff @@ ## main #2989 +/- ## ========================================== + Coverage 87.12% 87.67% +0.56% ========================================== Files 200 190 -10 Lines 6109 5855 -254 ========================================== - Hits 5322 5133 -189 + Misses 787 722 -65 ``` [see 110 files with indirect coverage changes](https://app.codecov.io/gh/open-telemetry/opentelemetry-cpp/pull/2989/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)
marcalff commented 3 months ago

See related: