open-telemetry / opentelemetry-cpp

The OpenTelemetry C++ Client
https://opentelemetry.io/
Apache License 2.0
889 stars 425 forks source link

[BUILD] Remove aligned_storage from nostd #3112

Closed ColoredCarrot closed 3 weeks ago

ColoredCarrot commented 4 weeks ago

Fixes #3111

Changes

Removes absl::aligned_storage, which uses std::aligned_storage, which was deprecated in C++23.

Abseil removed its aligned_storage in https://github.com/abseil/abseil-cpp/commit/42133464db0ae5383fef723067835ef768b849f8

linux-foundation-easycla[bot] commented 4 weeks ago

CLA Signed


The committers listed above are authorized under a signed CLA.

netlify[bot] commented 4 weeks ago

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
Latest commit ff3867297bdb0d818f430997e300fb63807a49b5
Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/671b79b760318d00083ea6fb
codecov[bot] commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.91%. Comparing base (497eaf4) to head (ff38672). Report is 148 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/open-telemetry/opentelemetry-cpp/pull/3112/graphs/tree.svg?width=650&height=150&src=pr&token=FJESTYQ2AD&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)](https://app.codecov.io/gh/open-telemetry/opentelemetry-cpp/pull/3112?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) ```diff @@ Coverage Diff @@ ## main #3112 +/- ## ========================================== + Coverage 87.12% 87.91% +0.79% ========================================== Files 200 195 -5 Lines 6109 6133 +24 ========================================== + Hits 5322 5391 +69 + Misses 787 742 -45 ``` [see 98 files with indirect coverage changes](https://app.codecov.io/gh/open-telemetry/opentelemetry-cpp/pull/3112/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)
marcalff commented 4 weeks ago

@ColoredCarrot

Thanks for the fix. Please sign the EasyCLA, so this can be merged.

ColoredCarrot commented 4 weeks ago

Thanks for the fix. Please sign the EasyCLA, so this can be merged.

Sure, should be good now.