open-telemetry / opentelemetry-cpp

The OpenTelemetry C++ Client
https://opentelemetry.io/
Apache License 2.0
890 stars 426 forks source link

[API] Comply with W3C Trace Context #3115

Closed psx95 closed 2 weeks ago

psx95 commented 3 weeks ago

Fixes #74

Changes

Details

The following lists shows all the failing tests. Checked box indicates that the changes in this PR have fixed the test.

Currently failing tests from TraceContextTest suite

Currently failing tests from AdvancedTest suite

NOTE: The tests above were part of test suites TraceContextTest & AdvancedTest. These test suites Trace Context Level 1 support.

Current Status

All tests now passing. Test suites ran - TraceContextTest & AdvancedTest.

Additional Tasks

For significant contributions please make sure you have completed the following items:

netlify[bot] commented 3 weeks ago

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
Latest commit 894c042412f3fb88793742000337e4bb20ec8169
Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/672b9015a2c39800089ba6cf
codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.

Project coverage is 87.83%. Comparing base (497eaf4) to head (894c042). Report is 154 commits behind head on main.

Files with missing lines Patch % Lines
...entelemetry/trace/propagation/http_trace_context.h 62.50% 3 Missing :warning:
api/include/opentelemetry/trace/trace_state.h 0.00% 1 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/open-telemetry/opentelemetry-cpp/pull/3115/graphs/tree.svg?width=650&height=150&src=pr&token=FJESTYQ2AD&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)](https://app.codecov.io/gh/open-telemetry/opentelemetry-cpp/pull/3115?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) ```diff @@ Coverage Diff @@ ## main #3115 +/- ## ========================================== + Coverage 87.12% 87.83% +0.72% ========================================== Files 200 195 -5 Lines 6109 6138 +29 ========================================== + Hits 5322 5391 +69 + Misses 787 747 -40 ``` | [Files with missing lines](https://app.codecov.io/gh/open-telemetry/opentelemetry-cpp/pull/3115?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) | Coverage Δ | | |---|---|---| | [api/include/opentelemetry/common/string\_util.h](https://app.codecov.io/gh/open-telemetry/opentelemetry-cpp/pull/3115?src=pr&el=tree&filepath=api%2Finclude%2Fopentelemetry%2Fcommon%2Fstring_util.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-YXBpL2luY2x1ZGUvb3BlbnRlbGVtZXRyeS9jb21tb24vc3RyaW5nX3V0aWwuaA==) | `100.00% <100.00%> (ø)` | | | [api/include/opentelemetry/trace/trace\_state.h](https://app.codecov.io/gh/open-telemetry/opentelemetry-cpp/pull/3115?src=pr&el=tree&filepath=api%2Finclude%2Fopentelemetry%2Ftrace%2Ftrace_state.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-YXBpL2luY2x1ZGUvb3BlbnRlbGVtZXRyeS90cmFjZS90cmFjZV9zdGF0ZS5o) | `97.60% <0.00%> (ø)` | | | [...entelemetry/trace/propagation/http\_trace\_context.h](https://app.codecov.io/gh/open-telemetry/opentelemetry-cpp/pull/3115?src=pr&el=tree&filepath=api%2Finclude%2Fopentelemetry%2Ftrace%2Fpropagation%2Fhttp_trace_context.h&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry#diff-YXBpL2luY2x1ZGUvb3BlbnRlbGVtZXRyeS90cmFjZS9wcm9wYWdhdGlvbi9odHRwX3RyYWNlX2NvbnRleHQuaA==) | `92.76% <62.50%> (-2.83%)` | :arrow_down: | ... and [99 files with indirect coverage changes](https://app.codecov.io/gh/open-telemetry/opentelemetry-cpp/pull/3115/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)