search

open-telemetry / opentelemetry-cpp

The OpenTelemetry C++ Client
https://opentelemetry.io/
Apache License 2.0
890 stars 426 forks source link

Set up for opentelemetry_proto_grpc_lib_type being shared #3136

Closed tjcw closed 1 week ago

tjcw commented 2 weeks ago

Caution, this patch may cause one of the tests to go into a loop

Fixes #3126 Buildability for AIX

Changes

cmake/opentelemetry-proto.cmake to make opentelemetry_proto_grpc library link with gRPC::grpc++ if building shared

This PR split off from #3127

linux-foundation-easycla[bot] commented 2 weeks ago

CLA Signed

The committers listed above are authorized under a signed CLA.

netlify[bot] commented 2 weeks ago

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
Latest commit e8e31ec45b4b46aaf13c2fa9bda18d983ea540f1
Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/67333640297f2100089083b7
codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.85%. Comparing base (497eaf4) to head (e8e31ec). Report is 161 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/open-telemetry/opentelemetry-cpp/pull/3136/graphs/tree.svg?width=650&height=150&src=pr&token=FJESTYQ2AD&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)](https://app.codecov.io/gh/open-telemetry/opentelemetry-cpp/pull/3136?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) ```diff @@ Coverage Diff @@ ## main #3136 +/- ## ========================================== + Coverage 87.12% 87.85% +0.73% ========================================== Files 200 195 -5 Lines 6109 6136 +27 ========================================== + Hits 5322 5390 +68 + Misses 787 746 -41 ``` [see 100 files with indirect coverage changes](https://app.codecov.io/gh/open-telemetry/opentelemetry-cpp/pull/3136/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)
DerrickLFX commented 2 weeks ago

/easycla

tjcw commented 1 week ago

Asking a colleague, it seems we no longer use the function that is set up by this PR. So I can close it. Please reopen another matching PR if you want to investigate why it causes the CI test to go into a loop.