open-telemetry / opentelemetry-cpp

The OpenTelemetry C++ Client
https://opentelemetry.io/
Apache License 2.0
890 stars 426 forks source link

[TEST] refactor UrlParser tests to use value-paramterized tests #3153

Closed sjinks closed 3 days ago

sjinks commented 6 days ago

As discussed in #3146

Changes

This PR refactors the UrlParser tests to make them more readable and use value-parametrized tests.

For significant contributions please make sure you have completed the following items:

netlify[bot] commented 6 days ago

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
Latest commit 3cc6bcb2def92fc412fd83a40edfced0ca539ecd
Latest deploy log https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/673ee4e6a253d700082346e6
codecov[bot] commented 6 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.86%. Comparing base (fe68d51) to head (3cc6bcb). Report is 1 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/open-telemetry/opentelemetry-cpp/pull/3153/graphs/tree.svg?width=650&height=150&src=pr&token=FJESTYQ2AD&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry)](https://app.codecov.io/gh/open-telemetry/opentelemetry-cpp/pull/3153?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=open-telemetry) ```diff @@ Coverage Diff @@ ## main #3153 +/- ## ======================================= Coverage 87.86% 87.86% ======================================= Files 195 195 Lines 6151 6151 ======================================= Hits 5404 5404 Misses 747 747 ```

🚨 Try these New Features:

marcalff commented 5 days ago

Waiting a bit for possible comments, then will merge.