Open sjinks opened 2 days ago
Name | Link |
---|---|
Latest commit | b006b8d1e10a74ac36a74b0faf8b47a19c0d6085 |
Latest deploy log | https://app.netlify.com/sites/opentelemetry-cpp-api-docs/deploys/673d3e007a6e020008624ad4 |
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 87.84%. Comparing base (
4d9cc28
) to head (b006b8d
).
🚨 Try these New Features:
Bazel on MacOS and IWYU failed for unrelated to this PR reasons; I cannot restart these jobs.
Waiting a bit for possible comments, then will merge.
Changes
This PR adds a test for
opentelemetry::exporter::logs::ElasticSearchRecordable
and updates the (disabled) tests for Elasticsearch Logs Exporter to ensure they compile.The plan is to refactor the ES Recordable to use the ADL Serializer. This will make the code much more readable and maintainable (no need to use
nostd::holds_alternative
orvalue.index()
+nostd::get()
and keep the list of the types up-to-date). That is why we need a test to make sure that the refactoring will not break the things.For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes